Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const init instead of lazy_static #97

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Use const init instead of lazy_static #97

merged 2 commits into from
Dec 8, 2022

Conversation

Expyron
Copy link
Contributor

@Expyron Expyron commented Dec 8, 2022

Split into two commit to simplify the review.

The MSRV for const Mutex::new() is 1.63.
I couldn't find the published MSRV for this crate, so I don't know if that's ok.

PolyMeilex
PolyMeilex approved these changes Dec 8, 2022
View reviewed changes
Copy link
Owner

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update of windows-rs recently bumped our MSRV to 1.64, so const mutex::new (1.63) is fine to use.

Thank you, looks good.

@PolyMeilex PolyMeilex merged commit f565c62 into PolyMeilex:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PolyMeilex PolyMeilex PolyMeilex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Expyron @PolyMeilex